feat(timetable): restore customizable timetables #3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3483 +/- ##
==========================================
- Coverage 53.22% 53.01% -0.21%
==========================================
Files 271 271
Lines 5860 5964 +104
Branches 1398 1436 +38
==========================================
+ Hits 3119 3162 +43
- Misses 2741 2802 +61
☔ View full report in Codecov by Sentry. |
zwliew
force-pushed
the
zwliew/feat/ta-timetable
branch
from
d28ce08
to
3d05c4f
Compare
zwliew
force-pushed
the
zwliew/feat/ta-timetable
branch
from
3d05c4f
to
6aae1ec
Compare
zwliew
force-pushed
the
zwliew/feat/ta-timetable
branch
from
6aae1ec
to
eeeb60f
Compare
zwliew
force-pushed
the
zwliew/feat/ta-timetable
branch
from
55f46f0
to
2e9a608
Compare
zwliew
force-pushed
the
zwliew/feat/ta-timetable
branch
from
6e901db
to
bbf2756
Compare
zwliew
force-pushed
the
zwliew/feat/ta-timetable
branch
from
bbf2756
to
0faf6e1
Compare
* feat: update lesson to array * chore: fix lint * fix: update test cases * chore: format lint * chore: update test cases * feat: update timetable redux schema * feat: fix lint * chore: fix lint * chore: add timetable schema migration test * fix: add comment for test version --------- Co-authored-by: Christopher Goh <[email protected]>
* feat: fix lint * feat: add customise module button * feat: add redux actions * feat: connect button to redux action * feat: enter and edit module * feat: exit customising state * cahnge customisemod default state to empty string * feat: add timetable state for custimised mods * feat: remove validation for custom mods * feat: add TA label to cells * feat: hide and disable other edit buttons when editing * feat: add support for changing lessons after customisation * chore: fix test cases * chore: fox lint * chore: fix schema migration test
zwliew
force-pushed
the
zwliew/feat/ta-timetable
branch
from
60a3650
to
61558e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This brings back PRs #3420 and #3434, which were reverted as part of PR #3435.
This re-resolves issue #3404.
Implementation
The original schema migration is faulty, so I added a minor fix for that.
Other Information
TODOs:
activeLessonsandcustomiseModulein the app state.